[ https://issues.apache.org/jira/browse/LUCENE-5452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13904675#comment-13904675 ]
Robert Muir commented on LUCENE-5452: ------------------------------------- Cool, maybe we can actually optimize the existing PQ stuff anyway (its not super-huper-duper optimized). But in general its bounded towards the number of matching sentences per doc, which is presumably quite small (there is some paper suggesting more than 5 is not that useful, so I assumed that). I'll take a look. The other thing that concerned me (and it may be just fine in your patch), is i couldn't tell if there was a little O(n^2) as far as fields go (fieldsIn * fieldsToMatchedFields), and the termsenum/docsenum/etc reuse across same segment became even more hairier than it is now (and its definitely ugly now). The final advantage of the "level above" would be, the multi-term highlighting etc would work for free. I'm gonna open a separate issue to try to improve some of this existing code, it was confusing to me just looking at it. > Combine matches from multiple fields into one with the postings highlighter > --------------------------------------------------------------------------- > > Key: LUCENE-5452 > URL: https://issues.apache.org/jira/browse/LUCENE-5452 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search > Reporter: Nik Everett > Priority: Minor > Attachments: LUCENE-5452.patch > > > Like you can do with the FVH, it'd be nice to be able combine matches from > multiple fields with the postings highlighter. > Note that the postings highlighter doesn't do phrase matching and doesn't use > term boosts so some of the FVH's field combining features won't work. It'd > be nice to get some of them, though. -- This message was sent by Atlassian JIRA (v6.1.5#6160) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org