[
https://issues.apache.org/jira/browse/LUCENE-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906056#comment-13906056
]
ASF GitHub Bot commented on LUCENE-5092:
----------------------------------------
GitHub user PaulElschot opened a pull request:
https://github.com/apache/lucene-solr/pull/37
Squashed commit for LUCENE-5092
LUCENE-5092
3rd pull request, resolved recent conflict with trunk.
In core introduce DocBlocksIterator.
Use this in FixedBitSet, in EliasFanoDocIdSet and in join module ToChild...
and ToParent...
Also change BaseDocIdSetTestCase to test
DocBlocksIterator.advanceToJustBefore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PaulElschot/lucene-solr LUCENE-5092-pull-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/37.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #37
----
commit 77f73ac206e8ad85bc7706424a7cc181eb73e8a9
Author: Paul Elschot <[email protected]>
Date: 2014-02-19T20:31:03Z
Squashed commit for LUCENE-5092
----
> join: don't expect all filters to be FixedBitSet instances
> ----------------------------------------------------------
>
> Key: LUCENE-5092
> URL: https://issues.apache.org/jira/browse/LUCENE-5092
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/join
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-5092.patch
>
>
> The join module throws exceptions when the parents filter isn't a
> FixedBitSet. The reason is that the join module relies on prevSetBit to find
> the first child document given a parent ID.
> As suggested by Uwe and Paul Elschot on LUCENE-5081, we could fix it by
> exposing methods in the iterators to iterate backwards. When the join modules
> gets an iterator which isn't able to iterate backwards, it would just need to
> dump its content into another DocIdSet that supports backward iteration,
> FixedBitSet for example.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
