[ https://issues.apache.org/jira/browse/LUCENE-5463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910676#comment-13910676 ]
Uwe Schindler edited comment on LUCENE-5463 at 2/24/14 7:14 PM: ---------------------------------------------------------------- In my opinion, the target should be named "-check-forbidden-core" instead of "-check-forbidden-sources". This would be more in line with "compile-core" targets and so on. We generally speak of "core" and "test" in our build files. was (Author: thetaphi): In my opinion, the target should be named "-check-forbidden-core" instead of "-souces". This would be more in line with "compile-core" and so on. > Make RamUsageEstimator.(human)sizeOf(Object) a forbidden API > ------------------------------------------------------------ > > Key: LUCENE-5463 > URL: https://issues.apache.org/jira/browse/LUCENE-5463 > Project: Lucene - Core > Issue Type: Task > Reporter: Adrien Grand > Assignee: Adrien Grand > Fix For: 4.8 > > Attachments: LUCENE-5463.patch, LUCENE-5463.patch > > > We have had a few issues with {{RamUsageEstimator}} recently so I think we > should consider making the {{sizeOf(Object)}} and {{humanSizeOf(Object)}} > methods forbidden under src/java (however still allowed for tests as it is > handy to check the size computations which are done "manually"). However, > {{sizeOf(byte[])}}, {{shallowSizeOf(Class)}}, etc. remain useful so I think > we should keep them allowed. -- This message was sent by Atlassian JIRA (v6.1.5#6160) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org