[ 
https://issues.apache.org/jira/browse/SOLR-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918803#comment-13918803
 ] 

Gregory Chanan commented on SOLR-5714:
--------------------------------------

New change looks good to me.

A couple of questions:
- Is there a test that checks that the global block cache is actually used?  I 
see that its turned on randomly, so we know turning it on doesn't break things, 
but does it actually do what it says it does?
- Are there any downsides to using a global block cache?  In the motivation 
above, it's to promote sharing on the same index, but we are sharing globally.  
Why not share on just the same index?

> You should be able to use one pool of memory for multiple collection's HDFS 
> block caches.
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-5714
>                 URL: https://issues.apache.org/jira/browse/SOLR-5714
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.8, 5.0
>
>         Attachments: SOLR-5714.patch, SOLR-5714.patch, SOLR-5714.patch
>
>
> Currently, you have to specify how much direct memory to allocate per 
> SolrCore. This can be inefficient, and has some negative consequences - for 
> instance, when replicating, many times two HDFS directories will exist for 
> the same index briefly, which will double the RAM used for that SolrCore.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to