[
https://issues.apache.org/jira/browse/LUCENE-5476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919311#comment-13919311
]
Rob Audenaerde commented on LUCENE-5476:
----------------------------------------
I will add the documentation to the XORShift64Random.
And of course, the tests. I have already some code that does testing in my mini
benchmark. I will reduce the document count, for the unit tests need to be as
fast as possible. Probably about 100 docs will do fine. Providing a seed will
make sure we can test exact; but I will try to also add a test that uses a
random seed and tests if the result fits in a given range. Should be doable,
will take the other tests as example.
Btw. I also tried the {{WAH8DocIdSet}} with {{setInterval(8)}}. It is slightly
slower (36 ms for FSB, 42 ms for WAH8) but it is a too small margin to draw
real conclusions I think. I agree it is better to have some tests first.
> Facet sampling
> --------------
>
> Key: LUCENE-5476
> URL: https://issues.apache.org/jira/browse/LUCENE-5476
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Rob Audenaerde
> Attachments: LUCENE-5476.patch, LUCENE-5476.patch, LUCENE-5476.patch,
> LUCENE-5476.patch, SamplingComparison_SamplingFacetsCollector.java,
> SamplingFacetsCollector.java
>
>
> With LUCENE-5339 facet sampling disappeared.
> When trying to display facet counts on large datasets (>10M documents)
> counting facets is rather expensive, as all the hits are collected and
> processed.
> Sampling greatly reduced this and thus provided a nice speedup. Could it be
> brought back?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
