[
https://issues.apache.org/jira/browse/LUCENE-5501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924011#comment-13924011
]
Robert Muir commented on LUCENE-5501:
-------------------------------------
Are you sure? I think its ok overall, but of course could be better:
>From a line coverage perspective, most of these are at or very close to 100%
Looking at test contributions against each, all the collectors in TopScore*
look like they get beat up pretty well.
TopField* is not so great, but with several tests trying to explicitly iterate
over all of them (TestSearchAfter, TestExpressionSorts, etc). More tests for
these sorting ones might be good, but I don't think the situation is so bad?
https://builds.apache.org/job/Lucene-Solr-Clover-trunk/clover/org/apache/lucene/search/TopScoreDocCollector.html#TopScoreDocCollector
https://builds.apache.org/job/Lucene-Solr-Clover-trunk/clover/org/apache/lucene/search/TopFieldCollector.html#TopFieldCollector
> Out-of-order collection testing
> -------------------------------
>
> Key: LUCENE-5501
> URL: https://issues.apache.org/jira/browse/LUCENE-5501
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Attachments: LUCENE-5501.patch
>
>
> Collectors have the ability to declare whether or not they support
> out-of-order collection, but since most scorers score in order this is not
> well tested.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
