[
https://issues.apache.org/jira/browse/SOLR-5825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13924642#comment-13924642
]
Erick Erickson commented on SOLR-5825:
--------------------------------------
I took a brief look, my question is why pass the SolrRequest to executeMethod?
It doesn't appear to be used. At least IntelliJ doesn't complain when I take it
out. Running tests now with it removed..
And I'm all for splitting that _huge_ method up.....
> Separate http request creation and execution in SolrJ
> -----------------------------------------------------
>
> Key: SOLR-5825
> URL: https://issues.apache.org/jira/browse/SOLR-5825
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Reporter: Steven Bower
> Assignee: Erick Erickson
> Attachments: SOLR-5825.patch
>
>
> In order to implement some custom behaviors I split the request() method in
> HttpSolrServer into 2 distinct method createMethod() and executeMethod().
> This allows for customization of either/both of these phases vs having it in
> a single function.
> In my use case I extended HttpSolrServer to support client side timeouts
> (so_timeout, connectTimeout and request timeout).. without duplicating the
> code in request() I couldn't accomplish..
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
