[ 
https://issues.apache.org/jira/browse/SOLR-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925887#comment-13925887
 ] 

Mark Miller commented on SOLR-5837:
-----------------------------------

The following also should be addressed:

{noformat}
+ } catch (IOException e) { 
+ //TODO fail test? 
+ } 
{noformat}

> Add missing equals implementation for SolrDocument, SolrInputDocument and 
> SolrInputField.
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-5837
>                 URL: https://issues.apache.org/jira/browse/SOLR-5837
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Varun Thacker
>            Assignee: Noble Paul
>             Fix For: 4.8, 5.0
>
>         Attachments: SOLR-5837.patch, SOLR-5837.patch
>
>
> While working on SOLR-5265 I tried comparing objects of SolrDocument, 
> SolrInputDocument and SolrInputField. These classes did not Override the 
> equals implementation. 
> The issue will Override equals and hashCode methods to the 3 classes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to