[
https://issues.apache.org/jira/browse/SOLR-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935394#comment-13935394
]
Mark Miller commented on SOLR-5864:
-----------------------------------
+1.
I think in 4x, we probably want to keep the old signatures and deprecate them.
Also, we should probably use a better variable name than prev now:
{noformat}
- if (!getNewIndexDir().equals(getIndexDir())) {
+ SolrCore prev;
+ if (getNewIndexDir().equals(getIndexDir())) {
+ prev = this;
+ } else {
// the directory is changing, don't pass on state
prev = null;
}
{noformat}
> Remove previous SolrCore as parameter on reload
> -----------------------------------------------
>
> Key: SOLR-5864
> URL: https://issues.apache.org/jira/browse/SOLR-5864
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0
> Reporter: Tomás Fernández Löbbe
> Priority: Trivial
> Attachments: SOLR-5864.patch, SOLR-5864.patch
>
>
> Currently the reload method is reload(SolrResourceLoader resourceLoader,
> SolrCore prev), but all the times it’s called with “prev” being the same as
> “this”:
> core.reload(resourceLoader, core).
> Frankly, I don’t think it even makes sense to call it in other way (it would
> be just to create the first reader with a different core than the one its
> being reloaded?)
> I think we should just remove the SolrCore parameter and let the "reload"
> method always reload the core where it's being called.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
