[
https://issues.apache.org/jira/browse/LUCENE-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943982#comment-13943982
]
Michael McCandless commented on LUCENE-5528:
--------------------------------------------
Thanks Areek, new patch looks great! It's nice that
Document/ExpressionDictionary, and the wrapping InputIterators
(Sorted/Unsorted) handle contexts as well. I think it's close.
I noticed a lot of added but unused "import import
org.apache.lucene.util.BytesRefIterator;" lines.
Also, AnalyzingInfixSuggester calls InputIterator.contexts() regardless of
whether hasContexts return true or false; I think this is actually OK, but can
you update InputIterator's javadocs to state that this is allowed, and
contexts() is expected to return null even if hasContexts() had returned false?
Finally just a small whitespace issue: instead of:
{noformat}
if(iterator.hasContexts()) {
{noformat}
Can you do this:
{noformat}
if (iterator.hasContexts()) {
{noformat}
(i.e. just add space between "if" and "("). Thanks!
> Add context to AnalyzingInfixSuggester
> --------------------------------------
>
> Key: LUCENE-5528
> URL: https://issues.apache.org/jira/browse/LUCENE-5528
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 4.8, 5.0
>
> Attachments: LUCENE-5528-1.patch, LUCENE-5528-1.patch,
> LUCENE-5528.patch, LUCENE-5528.patch, contextInputIteratImpl.patch
>
>
> Spinoff from LUCENE-5350.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
