[
https://issues.apache.org/jira/browse/SOLR-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949431#comment-13949431
]
Aaron Daubman commented on SOLR-2052:
-------------------------------------
I am looking to add some tests to demonstrate the caching still works correctly
with these changes per Hoss' recommendation on #solr.
In the meantime, maybe it is worth pointing out that at some point several
places that in the past did not handle both a list of filter queries and a
docset filter being set at the same time were updated to use
searcher.getProcessedFilter(cmd.getFilter(), cmd.getFilterList()) - which does
appear to handle the case where both are set appropriately...
...this confuses me even more, since the defensive assertions in
SolrIndexSearcher attempt to prevent both of these from being set, and yet
getProcessedFilter has been updated to handle the case where both are set
appropriately (as far as I can tell). It does look like this works correctly
with caching as well - I am now just trying to figure out the right way and
place to add tests to demonstrate this.
> Allow for a list of filter queries and a single docset filter in
> QueryComponent
> -------------------------------------------------------------------------------
>
> Key: SOLR-2052
> URL: https://issues.apache.org/jira/browse/SOLR-2052
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 4.0-ALPHA
> Environment: Mac OS X, Java 1.6
> Reporter: Stephen Green
> Priority: Minor
> Fix For: 4.8
>
> Attachments: SOLR-2052-2.patch, SOLR-2052-3-6-1.patch,
> SOLR-2052-3.patch, SOLR-2052-4.patch, SOLR-2052-4_0_0.patch,
> SOLR-2052-trunk.patch, SOLR-2052.patch
>
>
> SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries
> or a single filter (as a DocSet), but not both. This restriction seems
> arbitrary, and there are cases where we can have both a list of filter
> queries and a DocSet generated by some other non-query process (e.g.,
> filtering documents according to IDs pulled from some other source like a
> database.)
> Fixing this requires a few small changes to SolrIndexSearcher to allow both
> of these to be set for a QueryCommand and to take both into account when
> evaluating the query. It also requires a modification to ResponseBuilder to
> allow setting the single filter at query time.
> I've run into this against 1.4, but the same holds true for the trunk.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
