I'll move it :) Mike McCandless
http://blog.mikemccandless.com On Thu, Mar 27, 2014 at 6:44 PM, Robert Muir <[email protected]> wrote: > The same test file does use linedocs. But not this test method. I > think you accidentally fixed the wrong method? There are other test > method(s) in this class using that buildIndex() method, which pulls > from linedocs. > > I think your change belongs there in some shape... > > On Thu, Mar 27, 2014 at 3:41 PM, Michael McCandless > <[email protected]> wrote: >> Indeed I was trying to fix any tests using LineFileDocs + MockAnalyzer >> but clearly I royally screwed up this case because that test case does >> not use LineFileDocs!! >> >> Sorry :( >> >> Thanks for fixing Rob. >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Thu, Mar 27, 2014 at 5:59 PM, Robert Muir <[email protected]> wrote: >>> But it makes no sense for this test at all. >>> >>> in one field this test indexes 0 terms. in the other field it indexes 1 >>> term. >>> >>> and the term is 9 characters long. >>> >>> On Thu, Mar 27, 2014 at 2:56 PM, Chris Hostetter >>> <[email protected]> wrote: >>>> >>>> : I don't know why this line was added in r1575538 "don't try to index >>>> : megaterms". Mike do you know? >>>> : >>>> : analyzer.setMaxTokenLength(TestUtil.nextInt(random(), 1, >>>> : IndexWriter.MAX_TERM_LENGTH)); >>>> >>>> I don't know if that specific change in that specific test is a bug or not >>>> (I haven't looked at MockAnalyzer in years), but i'm pretty sure the >>>> context of r1575538 as a whole was this progression of failures after >>>> LUCENE-5472 was committed... >>>> >>>> https://mail-archives.apache.org/mod_mbox/lucene-dev/201403.mbox/%3CCAL8Pwkahw=cooln5w7muxq2+8mntzetqzh8dkprk_ibpvd9...@mail.gmail.com%3E >>>> http://svn.apache.org/r1574917 >>>> >>>> https://mail-archives.apache.org/mod_mbox/lucene-dev/201403.mbox/%3CCAL8PwkYAzTsfekHyW4E7Yp6K=sz-f0wdecepu8520pg1o1k...@mail.gmail.com%3E >>>> http://svn.apache.org/r1575520 >>>> >>>> ...i suspect mikemccand was trying to get a jump on other tests that would >>>> trigger similar problems. >>>> >>>> >>>> -Hoss >>>> http://www.lucidworks.com/ >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
