[ 
https://issues.apache.org/jira/browse/SOLR-5920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated SOLR-5920:
-----------------------------

    Attachment: SOLR-5920.patch

Patch, fixing up several issues found by Hoss (from #solr IRC):

* {{CursorMarkTest.buildRandomSortObjects()}} is now streamlined and easier to 
read.
* The new {{icu_collation_*}} fields in {{schema-sorts.xml}} now actually use 
{{ICUCollationField}} (previously was mistakenly {{CollationField}}).  I also 
had to make changes to the Ant build to build {{lucene/analysis/icu/}} and 
{{solr/contrib/analysis-extras/}}, and include their build output and the ICU4J 
jar in solr-core's test classpath.  IntelliJ config changes along the same 
lines are also included.
* In {{schema-sorts.xml}}, the {{bcd_str_*}} ({{BCDStrField}}) fields are now 
copied from the {{int}} field rather from the {{long}} field ({{BCDStrField}} 
extends {{BCDIntField}}).
* All UUID field values are now generated on the spot, rather than via the 
"NEW" delayed-instantiation method, to allow distributed UUID sort testing.


I've also added a CHANGES.txt entry.  

This is ready to go.  I'm committing shortly, and will backport to branch_4x 
and the lucene_solr_4_7 branch, and then cut 4.7.1 RC2.

The patch also includes a fix to {{FloatField.getSortField()}} to allow 
{{CursorPagingTest.testRandomSortsOnLargeIndex()}} to succeed:

{noformat}
@@ -70,7 +70,7 @@
   @Override
   public SortField getSortField(SchemaField field,boolean reverse) {
     field.checkSortability();
-    return new SortField(field.name,SortField.Type.FLOAT, reverse);
+    return new SortField(field.name, PARSER, reverse);
   }
{noformat}

 ({{PARSER}} is a {{FieldCache.FloatParser}} defined above in {{FloatField}}.)  
Without the above change (which makes {{FloatField.getSortField()}} the same as 
the current {{DoubleField.getSortField()}}), I get the following exception from 
{{CursorPagingTest.testRandomSortsOnLargeIndex()}}:

{noformat}
22160 T11 C147 oasc.SolrCore.execute [collection1] webapp=null path=null 
params={q=*%3A*&fl=id&rows=50&sort=icu_collation_en_primary+desc%2C+id+desc&cursorMark=AoIAQQ%3D%3D}
 hits=187 status=0 QTime=1 
22163 T11 C147 oasc.SolrException.log ERROR java.lang.NumberFormatException: 
Invalid shift value in prefixCoded bytes (is encoded value really an INT?)
                at 
org.apache.lucene.util.NumericUtils.getPrefixCodedIntShift(NumericUtils.java:210)
                at 
org.apache.lucene.util.NumericUtils$2.accept(NumericUtils.java:493)
                at 
org.apache.lucene.index.FilteredTermsEnum.next(FilteredTermsEnum.java:235)
                at 
org.apache.lucene.search.FieldCacheImpl$Uninvert.uninvert(FieldCacheImpl.java:305)
                at 
org.apache.lucene.search.FieldCacheImpl$FloatCache.createValue(FieldCacheImpl.java:659)
                at 
org.apache.lucene.search.FieldCacheImpl$Cache.get(FieldCacheImpl.java:209)
                at 
org.apache.lucene.search.FieldCacheImpl.getFloats(FieldCacheImpl.java:595)
                at 
org.apache.lucene.search.FieldCacheImpl$FloatCache.createValue(FieldCacheImpl.java:626)
                at 
org.apache.lucene.search.FieldCacheImpl$Cache.get(FieldCacheImpl.java:209)
                at 
org.apache.lucene.search.FieldCacheImpl.getFloats(FieldCacheImpl.java:595)
                at 
org.apache.lucene.search.FieldComparator$FloatComparator.setNextReader(FieldComparator.java:379)
                at 
org.apache.lucene.search.TopFieldCollector$MultiComparatorNonScoringCollector.setNextReader(TopFieldCollector.java:452)
                at 
org.apache.solr.search.SolrIndexSearcher.sortDocSet(SolrIndexSearcher.java:2034)
                at 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1388)
                at 
org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:479)
                at 
org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:461)
                at 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:221)
                at 
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
                at org.apache.solr.core.SolrCore.execute(SolrCore.java:1952)
                at org.apache.solr.util.TestHarness.query(TestHarness.java:295)
                at org.apache.solr.util.TestHarness.query(TestHarness.java:278)
                at 
org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:819)
                at 
org.apache.solr.SolrTestCaseJ4.assertJQ(SolrTestCaseJ4.java:788)
                at 
org.apache.solr.CursorPagingTest.assertFullWalkNoDups(CursorPagingTest.java:685)
                at 
org.apache.solr.CursorPagingTest.testRandomSortsOnLargeIndex(CursorPagingTest.java:578)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
                at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
                at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
                at java.lang.reflect.Method.invoke(Method.java:606)
                at 
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1617)
                at 
com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:826)
                at 
com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:862)
                at 
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:876)
                at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:53)
                at 
org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:50)
                at 
org.apache.lucene.util.TestRuleFieldCacheSanity$1.evaluate(TestRuleFieldCacheSanity.java:51)
                at 
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:46)
                at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:55)
                at 
org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:49)
                at 
org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:70)
                at 
org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48)
                at 
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
                at 
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:359)
                at 
com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:783)
                at 
com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:443)
                at 
com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:835)
                at 
com.carrotsearch.randomizedtesting.RandomizedRunner$3.evaluate(RandomizedRunner.java:737)
                at 
com.carrotsearch.randomizedtesting.RandomizedRunner$4.evaluate(RandomizedRunner.java:771)
                at 
com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:782)
                at 
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
                at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:53)
                at 
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:46)
                at 
org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:42)
                at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:55)
                at 
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39)
                at 
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39)
                at 
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
                at 
org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:43)
                at 
org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48)
                at 
org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:70)
                at 
org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:55)
                at 
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
                at 
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:359)
                at java.lang.Thread.run(Thread.java:724)
{noformat}

> Distributed sort on DateField, BoolField and BCD{Int,Long,Str}Field returns 
> string cast exception
> -------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-5920
>                 URL: https://issues.apache.org/jira/browse/SOLR-5920
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 4.7
>         Environment: Debian, Java JVM 1.6.0_26
>            Reporter: Eric Bus
>            Assignee: Steve Rowe
>              Labels: datefield, exception, sort
>             Fix For: 4.8, 5.0, 4.7.1
>
>         Attachments: SOLR-5920.patch, SOLR-5920.patch
>
>
> After upgrading to 4.7, sorting on a date field returns the folllow trace:
> {quote}
> <?xml version="1.0" encoding="UTF-8"?>
> <response>
> <lst name="responseHeader"><int name="status">500</int><int 
> name="QTime">7</int></lst><lst name="error"><str name="msg">java.lang.String 
> cannot be cast to org.apache.lucene.util.BytesRef</str><str 
> name="trace">java.lang.ClassCastException: java.lang.String cannot be cast to 
> org.apache.lucene.util.BytesRef
>       at 
> org.apache.lucene.search.FieldComparator$TermOrdValComparator.compareValues(FieldComparator.java:940)
>       at 
> org.apache.solr.handler.component.ShardFieldSortedHitQueue$2.compare(ShardDoc.java:245)
>       at 
> org.apache.solr.handler.component.ShardFieldSortedHitQueue$2.compare(ShardDoc.java:237)
>       at 
> org.apache.solr.handler.component.ShardFieldSortedHitQueue.lessThan(ShardDoc.java:162)
>       at 
> org.apache.solr.handler.component.ShardFieldSortedHitQueue.lessThan(ShardDoc.java:104)
>       at 
> org.apache.lucene.util.PriorityQueue.insertWithOverflow(PriorityQueue.java:159)
>       at 
> org.apache.solr.handler.component.QueryComponent.mergeIds(QueryComponent.java:909)
>       at 
> org.apache.solr.handler.component.QueryComponent.handleRegularResponses(QueryComponent.java:661)
>       at 
> org.apache.solr.handler.component.QueryComponent.handleResponses(QueryComponent.java:640)
>       at 
> org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:321)
>       at 
> org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
>       at org.apache.solr.core.SolrCore.execute(SolrCore.java:1916)
>       at 
> org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:780)
>       at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:427)
>       at 
> org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:217)
>       at 
> org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1419)
>       at 
> org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
>       at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
>       at 
> org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
>       at 
> org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
>       at 
> org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1075)
>       at 
> org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:384)
>       at 
> org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
>       at 
> org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1009)
>       at 
> org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
>       at 
> org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
>       at 
> org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
>       at 
> org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
>       at org.eclipse.jetty.server.Server.handle(Server.java:368)
>       at 
> org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
>       at 
> org.eclipse.jetty.server.BlockingHttpConnection.handleRequest(BlockingHttpConnection.java:53)
>       at 
> org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:942)
>       at 
> org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1004)
>       at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:640)
>       at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
>       at 
> org.eclipse.jetty.server.BlockingHttpConnection.handle(BlockingHttpConnection.java:72)
>       at 
> org.eclipse.jetty.server.bio.SocketConnector$ConnectorEndPoint.run(SocketConnector.java:264)
>       at 
> org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
>       at 
> org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
>       at java.lang.Thread.run(Thread.java:662)
> </str><int name="code">500</int></lst>
> </response>
> {quote}
> The date field is specified as:
> {quote}<fieldType name="date" class="solr.DateField" sortMissingLast="true" 
> omitNorms="true"/>{quote}
> And it's used as a dynamic field:
> {quote}<dynamicField name="date_*" type="date" indexed="true" stored="true" 
> />{quote}
> Nothing in this configuration has changed since 4.6.1.
> Sorting on other values, like integers and text, works fine. Only date fields 
> are a problem.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to