[ 
https://issues.apache.org/jira/browse/LUCENE-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935731#action_12935731
 ] 

Robert Muir commented on LUCENE-2348:
-------------------------------------

Trejkaz, i think you are confused.

This is only a special case of TopFieldCollector, your notes about 
Hits/Hitcollector are irrelevant.

The situation here is it should never have been a filter in the first place, 
this is a bad design.
So I plan to commit this patch in a few days, as well as marking @deprecated.

If someone wants to later provide a 'replacement' thats fine, but this is 
contrib, and its not necessary
for us provide one to deprecate problems like this!


> DuplicateFilter incorrectly handles multiple calls to getDocIdSet for segment 
> readers
> -------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2348
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2348
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: contrib/*
>    Affects Versions: 2.9.2
>            Reporter: Trejkaz
>         Attachments: LUCENE-2348.patch, LUCENE-2348.patch
>
>
> DuplicateFilter currently works by building a single doc ID set, without 
> taking into account that getDocIdSet() will be called once per segment and 
> only with each segment's local reader.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to