[ 
https://issues.apache.org/jira/browse/LUCENE-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated LUCENE-5565:
---------------------------------

    Attachment: LUCENE-5565_SPT_remove_String.patch

The attached patch:
* removes String based token of Cell & SpatialPrefixTree.  Geohash Cell still 
uses Strings though; Quad was improved to not.
* renamed getTokenBytes() to getTokenBytesNoLeaf(), plus added getTokenBytes() 
that will have a leaf if the leaf is set.
* instead of using a boolean leaf flag; we examine the encoding
* Cell is no longer Comparable (wasn't  needed)
* The former inner class CellTokenStream is now its own class and modeled 
heavily off of NumericTokenStream.

I'll do a performance test to ensure the performance is at least the same.

> Remove String based encoding from SpatialPrefixTree/Cell API; just use bytes
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-5565
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5565
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>         Attachments: LUCENE-5565_SPT_remove_String.patch
>
>
> The SpatialPrefixTree/Cell API supports bytes and String encoding/decoding 
> dually.  I want to remove the String side to keep the API simpler.  Included 
> in this issue, I'd like to make some small refactorings to reduce assumptions 
> the filters make of the underlying encoding such that future encodings can 
> work a in more different ways with less impact on the filters.
> String encode/decode will exist for the Geohash one for now since 
> GeohashUtils works off of Strings, but Quad could change more easily.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to