[
https://issues.apache.org/jira/browse/LUCENE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959096#comment-13959096
]
Tim Smith commented on LUCENE-5569:
-----------------------------------
-1
please don't do this
renaming things for the sake of renaming them is a horrible burden on people
using these apis
for instance, every single minor version of lucene 4.x has broken api
signatures, resulting in hours, or days worth of time to reconcile the changes
add in a major name change like this and it adds in significant noise to fixing
any real compile errors and significantly complicates the porting process (it
took me weeks to upgrade from lucene 3.x to 4.x, i don't want to do that again)
AtomicReader is a public api in lucene and should not be renamed just because a
new name seems better
> Rename AtomicReader to LeafReader
> ---------------------------------
>
> Key: LUCENE-5569
> URL: https://issues.apache.org/jira/browse/LUCENE-5569
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Fix For: 5.0
>
>
> See LUCENE-5527 for more context: several of us seem to prefer {{Leaf}} to
> {{Atomic}}.
> Talking from my experience, I was a bit confused in the beginning that this
> thing is named {{AtomicReader}}, since {{Atomic}} is otherwise used in Java
> in the context of concurrency. So maybe renaming it to {{Leaf}} would help
> remove this confusion and also carry the information that these readers are
> used as leaves of top-level readers?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
