[ 
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979227#comment-13979227
 ] 

Mark Miller commented on SOLR-5473:
-----------------------------------

I have to make an official -1 veto vote on this issue.

The issue is to break clusterstate.json into one per collection instead of a 
global one. This format change in ZooKeeper should not ripple in such an ugly 
manner through all of our cloud API's. We should also be dropping the global 
clusterstate.json in 5, so there is no way any of these crazy API changes 
should exist. If anything, the new API's should be clean and we should have 
uglier back compat stuff.

As it is, it seems like things were hacked in the shortest route possible - and 
while that's great for a prototype or straw man impl, it's a horrendous 
direction for all these API's.

There is a lot of general clean up to do, but more importantly, there are 
problems we need to solve without muddling up all the cloud API's.

The way things are done now, there is not even a reason for stateFormat=1 or 2 
- that was clearly just jammed on top of what was going on anyway, with little 
thought or integration.

I have to veto this, it's way to crazy still. The work needs to be done to keep 
this from bubbling through all these API's so terribly and trunk is not the 
place to do it. It's too far from ready and will cause too much pain with 4x 
backports.

> Make one state.json per collection
> ----------------------------------
>
>                 Key: SOLR-5473
>                 URL: https://issues.apache.org/jira/browse/SOLR-5473
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrCloud
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>             Fix For: 5.0
>
>         Attachments: SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, 
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, 
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, 
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, 
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, ec2-23-20-119-52_solr.log, 
> ec2-50-16-38-73_solr.log
>
>
> As defined in the parent issue, store the states of each collection under 
> /collections/collectionname/state.json node



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to