[ https://issues.apache.org/jira/browse/LUCENE-5633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-5633: ------------------------------- Attachment: LUCENE-5633.patch Patch removes the two singletons and adds a single INSTANCE. Also .useCompoundFile returns newSegment.info.isCompound. The majority of the patch is in test classes which made use of these singletons (for no good reason!). All tests pass. > NoMergePolicy should have one singleton - NoMergePolicy.INSTANCE > ---------------------------------------------------------------- > > Key: LUCENE-5633 > URL: https://issues.apache.org/jira/browse/LUCENE-5633 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Varun Thacker > Priority: Minor > Attachments: LUCENE-5633.patch > > > Currently there are two singletons available - MergePolicy.NO_COMPOUND_FILES > and MergePolicy.COMPOUND_FILES and it's confusing to distinguish on compound > files when the merge policy never merges segments. > We should have one singleton - NoMergePolicy.INSTANCE > Post to the relevant discussion - > http://mail-archives.apache.org/mod_mbox/lucene-java-user/201404.mbox/%3CCAOdYfZXXyVSf9%2BxYaRhr5v2O4Mc6S2v-qWuT112_CJFYhWTPqw%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org