[ https://issues.apache.org/jira/browse/SOLR-3671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989759#comment-13989759 ]
ASF subversion and git services commented on SOLR-3671: ------------------------------------------------------- Commit 1592585 from jd...@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1592585 ] SOLR-3671: DIHWriter fix > DIH doesn't use its own interface + writerImpl has no information about the > request > ----------------------------------------------------------------------------------- > > Key: SOLR-3671 > URL: https://issues.apache.org/jira/browse/SOLR-3671 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler > Affects Versions: 4.0-ALPHA, 4.0-BETA > Reporter: Roman Chyla > Assignee: James Dyer > Priority: Minor > Attachments: SOLR-3671.patch, SOLR-3671.patch > > > The use case: I would like to extend DIH by providing a new writer, I have > tried everything but can't accomplish it without either a) duplicating whole > DIHandler or b) java reflection tricks. Almost everything inside DIH is > private and the mechanism to instantiate a new writer based on the > 'writerImpl' mechanism seems lacking important functionality > It doesn't give the new class a chance to get information about the request, > update processor. Also, the writer is instantiated twice (when 'writerImpl' > is there), which is really unnecessary. > As a solution, the existing DIHandler.getSolrWriter() should instantiate the > appropriate writer and send it to DocBuilder (it is already doing that for > SolrWriter). And DocBuilder doesn't need to create a second (duplicate) writer -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org