[ https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000237#comment-14000237 ]
Dawid Weiss commented on LUCENE-5650: ------------------------------------- I think your last patch was inconsistent -- it didn't include the new rule, for example (only patched javaTempDir.getAbsoluteFile). I've tried to consolidate all of it and pushed it to a branch: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene5650 I'm running the tests right now. I still didn't know what to make of the nocommit -- please fix it on the branch, add CHANGES entry and I think we're ready to go? > createTempDir and associated functions no longer create java.io.tmpdir > ---------------------------------------------------------------------- > > Key: LUCENE-5650 > URL: https://issues.apache.org/jira/browse/LUCENE-5650 > Project: Lucene - Core > Issue Type: Improvement > Components: general/test > Reporter: Ryan Ernst > Assignee: Dawid Weiss > Priority: Minor > Fix For: 4.9, 5.0 > > Attachments: LUCENE-5650.patch, LUCENE-5650.patch, LUCENE-5650.patch, > LUCENE-5650.patch > > > The recent refactoring to all the create temp file/dir functions (which is > great!) has a minor regression from what existed before. With the old > {{LuceneTestCase.TEMP_DIR}}, the directory was created if it did not exist. > So, if you set {{java.io.tmpdir}} to {{"./temp"}}, then it would create that > dir within the per jvm working dir. However, {{getBaseTempDirForClass()}} > now does asserts that check the dir exists, is a dir, and is writeable. > Lucene uses {{"."}} as {{java.io.tmpdir}}. Then in the test security > manager, the per jvm cwd has read/write/execute permissions. However, this > allows tests to write to their cwd, which I'm trying to protect against (by > setting cwd to read/execute in my test security manager). -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org