[ 
https://issues.apache.org/jira/browse/SOLR-6073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998681#comment-13998681
 ] 

Varun Thacker commented on SOLR-6073:
-------------------------------------

There are a few createCollection methods with hardcoded router="compositeId' 
also.

Would this be a correct approach going forward ?

Rename Create to CreateCollection which takes the collection name and the 
remaining params can be set using the setters.
Then have users create the CreateCollection object and the call 
req.process(server);

Something like - 
{noformat}
CreateCollection req = new CreateCollection("collection1");
req.setConfigName("");
...
req.process(server)
{noformat}

We could then deprecate all the createCollection methods in 4.x


> CollectionAdminRequest has createCollection methods with hard-coded 
> router="implicit"
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-6073
>                 URL: https://issues.apache.org/jira/browse/SOLR-6073
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java, SolrCloud
>    Affects Versions: 4.8
>            Reporter: Shalin Shekhar Mangar
>             Fix For: 4.9, 5.0
>
>
> The CollectionAdminRequest has a createCollection() method which has the 
> following hard-coded:
> {code}
> req.setRouterName("implicit");
> {code}
> This is a bug and we should remove it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to