[
https://issues.apache.org/jira/browse/LUCENE-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-5678:
----------------------------------
Attachment: LUCENE-5678.patch
Hi,
I cleaned up most of the code. This now makes BufferedIndexOutput obsolete
(once I fixed RateLimiter, which buffers a second time!!! horrible!!!).
But before I do this, we should check the perf, because this is now completely
different code.
I also fixed HdfsDirectory to use this new class, too.
The only remaining use of BufferedIndexOutput is in RateLimiter. I think we
should plug the rate limiter deeper on the OutputStream level in future
(subclass BufferedOutputStream to limit rate) and allow to plug that into the
FSDir impl.
> Investigate to use FileoutputStream instead of RandomAccessFile in
> FSIndexOutput
> --------------------------------------------------------------------------------
>
> Key: LUCENE-5678
> URL: https://issues.apache.org/jira/browse/LUCENE-5678
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/store
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Attachments: LUCENE-5678.patch, LUCENE-5678.patch
>
>
> We no longer allow seeking in IndexOutput, so there is no need to use
> RandomAccessFile. We can change this with a < 1 KiB patch.
> Further improvements would be to merge this with OutputStreamIndexOutput, so
> we get many simplifications.
> There is also no reason anymore to separate DataOutput from IndexOutput. The
> only additional thing is IndexOutput#getFilePointer(), which is handled by
> an internal counter (does not use getFilePointer of the underlying RAF) and
> checksums.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
