[
https://issues.apache.org/jira/browse/LUCENE-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004367#comment-14004367
]
Dawid Weiss commented on LUCENE-5650:
-------------------------------------
Commit it to the branch, Ryan. I fixed it the way I understand how Solr's
source code works (which is to say: vaguely familiar). I'm sure your patch is
better.
The build yesterday ended with this failure related to perm. denied:
{code}
[13:07:35.284] ERROR 0.00s J1 | TestFoldingMultitermExtrasQuery (suite) <<<
> Throwable #1: org.apache.solr.common.SolrException: SolrCore 'collection1' is
> not available due to init failure: access denied ("java.io.FilePermission"
> "analysis-extras\solr\collection1\conf" "write")
{code}
and the following, I guess notorious offenders:
{code}
- org.apache.solr.spelling.suggest.TestAnalyzeInfixSuggestions (could not
remove temp. files)
- TestBlendedInfixSuggestions (same thing)
- org.apache.solr.cloud.SyncSliceTest.testDistribSearch
> Throwable #1: org.apache.solr.client.solrj.SolrServerException: No live
SolrServers available to handle this request
- org.apache.solr.cloud.RecoveryZkTest.testDistribSearch
> Throwable #1: java.lang.AssertionError: shard1 is not consistent. Got 92
from https://127.0.0.1:54379/_koq/fr/collection1lastClient and got 60 from
https://127.0.0.1:54410/_koq/fr/collection1
{code}
I won't be able to return to this today (maybe in the evening). Change my DIH
fixes to yours on the branch -- I don't mind at all.
> createTempDir and associated functions no longer create java.io.tmpdir
> ----------------------------------------------------------------------
>
> Key: LUCENE-5650
> URL: https://issues.apache.org/jira/browse/LUCENE-5650
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/test
> Reporter: Ryan Ernst
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 4.9, 5.0
>
> Attachments: LUCENE-5650.patch, LUCENE-5650.patch, LUCENE-5650.patch,
> LUCENE-5650.patch, dih.patch
>
>
> The recent refactoring to all the create temp file/dir functions (which is
> great!) has a minor regression from what existed before. With the old
> {{LuceneTestCase.TEMP_DIR}}, the directory was created if it did not exist.
> So, if you set {{java.io.tmpdir}} to {{"./temp"}}, then it would create that
> dir within the per jvm working dir. However, {{getBaseTempDirForClass()}}
> now does asserts that check the dir exists, is a dir, and is writeable.
> Lucene uses {{"."}} as {{java.io.tmpdir}}. Then in the test security
> manager, the per jvm cwd has read/write/execute permissions. However, this
> allows tests to write to their cwd, which I'm trying to protect against (by
> setting cwd to read/execute in my test security manager).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
