[
https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-5645:
---------------------------------
Attachment: LUCENE-5645_StringHelper_empty_tests_seed_condition.patch
The following patch addresses my concern (throwing an exception) as well as
Rob's (reproducible test, even when tests.seed is the empty string).
I also noticed oddly that the string length condition was checking if the
string was greater than characters to then parse all but the last 8 characters
(which hypothetically might be more than 8 characters). I changed this to only
grab the first 8 characters, and to use Integer.parseInt since an int is needed
instead of using a Long then casting.
> StringHelper should check for empty string of "tests.seed" system property
> --------------------------------------------------------------------------
>
> Key: LUCENE-5645
> URL: https://issues.apache.org/jira/browse/LUCENE-5645
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.8, 5.0
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 4.8.1, 5.0
>
> Attachments: LUCENE-5645_StringHelper_empty_tests_seed_condition.patch
>
>
> As of LUCENE-5604 (committed to v4.8), StringHelper will initialize
> GOOD_FAST_HASH_SEED based on the system property "tests.seed" if it is set.
> Unfortunately it doesn't do an empty-string check, and it's common at least
> in my setup that copies Lucene's maven pom.xml that the string will be empty
> unless I set it on the command line. FWIW Randomized Testing does do an
> empty-string check.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
