[ 
https://issues.apache.org/jira/browse/LUCENE-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018541#comment-14018541
 ] 

Robert Muir commented on LUCENE-5703:
-------------------------------------

I tried to just make TermOrdValComparator.MISSING_BYTESREF an instance variable 
instead of static as an easy-fix, but this uncovered a real bug: it break 
searchAfter. We have to assume users will want to deserialize results there... 
we can't rely upon them providing back that exact same bytesref as the missing 
value. Having it as a static only hid that in tests.

> Don't allocate/copy bytes all the time in binary DV producers
> -------------------------------------------------------------
>
>                 Key: LUCENE-5703
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5703
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: 4.9, 5.0
>
>         Attachments: LUCENE-5703.patch, LUCENE-5703.patch, LUCENE-5703.patch, 
> LUCENE-5703.patch, LUCENE-5703.patch, LUCENE-5703.patch
>
>
> Our binary doc values producers keep on creating new {{byte[]}} arrays and 
> copying bytes when a value is requested, which likely doesn't help 
> performance. This has been done because of the way fieldcache consumers used 
> the API, but we should try to fix it in 5.0.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to