[ 
https://issues.apache.org/jira/browse/SOLR-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14033988#comment-14033988
 ] 

Steve Rowe commented on SOLR-6164:
----------------------------------

+1, this looks great [~gchanan] - the code to update copyfields just wasn't 
there at all previously.  I want to get this into the 4.9 release - I'll commit 
shortly.

Separately, {{ManagedIndexSchema.shallowCopy()}} is geared exclusively toward 
what addFields() needs - other modifications aren't dealt with.  I think it 
should be reworked to just shallowly copy everything, and then the pieces that 
need to be can be handled in the reloading code.  Not sure how to detect that 
reloading of any piece is required ... maybe some form of checksum over the 
sorted serialized pieces?  I guess just always reloading - as is currently done 
for both fields and copyFields now too - is at least correct, if not the most 
performant solution.

> Copy Fields Schema additions are not distributed to other nodes
> ---------------------------------------------------------------
>
>                 Key: SOLR-6164
>                 URL: https://issues.apache.org/jira/browse/SOLR-6164
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Gregory Chanan
>         Attachments: SOLR-6164.patch, SOLR-6164v2.patch
>
>
> I took a closer look at the tests added in SOLR-6145, and the copy fields 
> aren't being distributed -- it just looks that way b/c we are adding the same 
> copy field directive multiple times to random servers and by chance, they'll 
> be added to all the servers.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to