[ 
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048831#comment-14048831
 ] 

Shai Erera commented on LUCENE-5801:
------------------------------------

Thanks for opening this, we definitely need to bring this class back. While 
you're at it, notice that there is a matching test as well as 
TaxonomyMergeUtils which did some work for the user ... we should consider 
returning them as well, but this time under o.a.l.facet.taxonomy.utils, as they 
are specific to the taxonomy index.

I think one change we should make is somehow expose FacetsConfig.dedupAndEncode 
as a static method, so you can encode the new ordinals and then:

* Take an OrdinalsReader in the ctor (optional, 2nd ctor) in case the app used 
custom encoding (default to DocValuesOrdinalsReader).
* Have a protected method dedupAndEncode, like FacetsConfig, default to 
FacetsConfig.dedupAndEncode and allow the app to override with its own custom 
encoding.

> Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader
> -----------------------------------------------------------------
>
>                 Key: LUCENE-5801
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5801
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.7
>            Reporter: Nicola Buso
>
> from lucene > 4.6.1 the class:
> org.apache.lucene.facet.util.OrdinalMappingAtomicReader
> was removed; resurrect it because used merging indexes related to merged 
> taxonomies.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to