[ https://issues.apache.org/jira/browse/LUCENE-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14057553#comment-14057553 ]
Adrien Grand commented on LUCENE-5812: -------------------------------------- This change doesn't look right to me: by having a class implementing {{Accountable}}, I would expect {{ramBytesUsed()}} to return memory usage for the whole instance, but in that case we only return memory usage for the NRT cache. I think this is confusing if the directory implementation that you are wrapping is not purely disk-based (such as BlockDirectory). > NRTCachingDirectory should implement Accountable > ------------------------------------------------ > > Key: LUCENE-5812 > URL: https://issues.apache.org/jira/browse/LUCENE-5812 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Simon Willnauer > Assignee: Simon Willnauer > Priority: Minor > Attachments: LUCENE-5812.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org