[
https://issues.apache.org/jira/browse/LUCENE-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071563#comment-14071563
]
Han Jiang commented on LUCENE-5841:
-----------------------------------
It is really great to see this interface removed!
> Remove FST.Builder.FreezeTail interface
> ---------------------------------------
>
> Key: LUCENE-5841
> URL: https://issues.apache.org/jira/browse/LUCENE-5841
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5841.patch
>
>
> The FST Builder has a crazy-hairy interface called FreezeTail, which is only
> used by BlockTreeTermsWriter to find appropriate prefixes
> (i.e. containing enough terms or sub-blocks) to write term blocks.
> But this is really a silly abuse ... it's cleaner and likely
> faster/less GC for BTTW to compute this itself just by tracking the
> term ordinal where each prefix started in the pending terms/blocks. The
> code is also insanely hairy, and this is at least a baby step to try
> to make it a bit simpler.
> This also makes it very hard to experiment with different formats at
> write-time because you have to get your new formats working through
> this strange FreezeTail.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
