[
https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969364#action_12969364
]
Yonik Seeley commented on LUCENE-2649:
--------------------------------------
bq. looks good to me
Cool - I'll work up a patch.
bq. The assumption is that once vals.valid is set, it should not be
recalculated.
Oh, tricky. We should comment that.
And we can then also change this:
OpenBitSet validBits = (hasOption(OPTION_CACHE_BITS)) ? new OpenBitSet(
maxDoc ) : null;
To this:
OpenBitSet validBits = (hasOption(OPTION_CACHE_BITS) && valid.vals==null) ?
new OpenBitSet( maxDoc ) : null;
> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
> Key: LUCENE-2649
> URL: https://issues.apache.org/jira/browse/LUCENE-2649
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 4.0
>
> Attachments: LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.
> However there is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a
> BitSet for all valid docs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
