[ 
https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969386#action_12969386
 ] 

Yonik Seeley commented on LUCENE-2671:
--------------------------------------

(carried over from LUCENE-2649... I guess my last patch should have been here.)

Actually, looking a bit further at these comparators, it seems like we have an 
unnecessary cast in the inner-loop method compareBottom (because of type 
erasure)?
Seems like we should just cache the int[] or whatever to avoid that.
I'll work up another patch for consideration.

> Add sort missing first/last ability to SortField and ValueComparator
> --------------------------------------------------------------------
>
>                 Key: LUCENE-2671
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2671
>             Project: Lucene - Java
>          Issue Type: New Feature
>          Components: Search
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>             Fix For: 4.0
>
>         Attachments: LUCENE-2671-caches.patch, LUCENE-2671-caches.patch, 
> LUCENE-2671-SortMissingLast.patch, LUCENE-2671-suppress-unchecked.patch
>
>
> When SortField and ValueComparator use EntryCreators (from LUCENE-2649) they 
> use a special sort value when the field is missing.
> This enables lucene to implement 'sort missing last' or 'sort missing first' 
> for numeric values from the FieldCache.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to