[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083962#comment-14083962
]
Jack Krupansky commented on SOLR-6315:
--------------------------------------
Is "order" a part of the contract for the usages of this class? I mean, the
current Javadoc does explicitly say that repetition and null values are NOT a
part of the contract, but it doesn't say that order, another feature of
NameList, is not important, while the name itself says "Ordered". Kind of
ambiguous, so a first order (Hah!) of business is to clarify whether
maintaining order is a part of the contract, and then to validate that contract
with actual usages.
Switching to "map" implies that order is no longer part of the contract, so it
will be free to vary from release to release or between JVMs. Personally, I
wish that Map was UnorderedMap, or even UnstableOrderMap, to make the contract
crystal clear.
In fact it would be great to have the ordering of serialization of Map be a
seeded random test framework parameter to catch cases where the code or test
cases have become dependent on order of map serialization or any other
non-contract behavior for that matter.
Will this change have ANY behavior change that will be visible to Solr
application developers or users?
> Remove SimpleOrderedMap
> -----------------------
>
> Key: SOLR-6315
> URL: https://issues.apache.org/jira/browse/SOLR-6315
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: SOLR-6315.patch
>
>
> As I described on SOLR-912, SimpleOrderedMap is redundant and generally
> useless class, with confusing jdocs. We should remove it. I'll attach a patch
> shortly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
