[
https://issues.apache.org/jira/browse/SOLR-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089230#comment-14089230
]
ASF GitHub Bot commented on SOLR-6336:
--------------------------------------
GitHub user andyetitmoves opened a pull request:
https://github.com/apache/lucene-solr/pull/80
Reuse watcher in DistributedQueue across peek/take
Initial patch for SOLR-6336. Some more work can probably be done (other
functions in the queue still do this, and probably tests would be good to check
this in general), but here's an initial fix which passes tests and fixes
Jenkins failures currently happening..
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr fix-watch-leak
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/80.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #80
----
commit d61f5de2056a4ea841c2d637b9def1c2cb8597b0
Author: Ramkumar Aiyengar <[email protected]>
Date: 2014-08-07T12:30:22Z
Reuse watcher in DistributedQueue across peek/take
----
> DistributedQueue (and it's use in OCP) leaks ZK Watches
> -------------------------------------------------------
>
> Key: SOLR-6336
> URL: https://issues.apache.org/jira/browse/SOLR-6336
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Ramkumar Aiyengar
>
> The current {{DistributedQueue}} implementation leaks ZK watches whenever it
> finds children or times out on finding one. OCP uses this in its event loop
> and can loop tight in some conditions (when exclusivity checks fail), leading
> to lots of watches which get triggered together on the next event (could be a
> while for some activities like shard splitting).
> This gets exposed by SOLR-6261 which spawns a new thread for every parallel
> watch event.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
