[ 
https://issues.apache.org/jira/browse/SOLR-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095460#comment-14095460
 ] 

ASF GitHub Bot commented on SOLR-6370:
--------------------------------------

GitHub user andyetitmoves opened a pull request:

    https://github.com/apache/lucene-solr/pull/84

    Allow tests to report/fail on many ZK watches being parallelly requested on 
the same data

    Initial patch for  SOLR-6370, starts off with conservative defaults (just 
show report at shutdown), but could be made stricter as we fix up issues this 
uncovers (there are lots which do show up).
    
    I opted to implement this on the server side so that the real 
{{SolrZkClient}} doesn't have to be modified for tests, and all tests are opted 
in by default.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bloomberg/lucene-solr trunk-latch-qc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/84.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #84
    
----
commit 86546e224cf5bf11f85dc081d4d3aaa13a93685f
Author: Ramkumar Aiyengar <[email protected]>
Date:   2014-08-12T05:02:31Z

    Allow tests to report/fail on many ZK watches being parallelly requested on 
the same data

----


> Allow tests to report/fail on many ZK watches being parallelly requested on 
> the same data
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-6370
>                 URL: https://issues.apache.org/jira/browse/SOLR-6370
>             Project: Solr
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Ramkumar Aiyengar
>            Priority: Minor
>
> Issues like SOLR-6336 uncovered cases where we were using too many ZK 
> watches. Watches are costly and we should fix such places but there's no good 
> way for tests to find out about them.
> This issue is for a mechanism for tests to report or fail on watches being 
> redundantly set on data. This would also allow for specific tests to 
> configure if there's a valid case for such a thing happening.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to