[
https://issues.apache.org/jira/browse/LUCENE-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097015#comment-14097015
]
Robert Muir commented on LUCENE-5886:
-------------------------------------
I will leave the issue open, in case we can fix the java 8 check. At some
point I think we want to support java 8 in ant tasks like this.
This also prevents annoyances for developers if they accidentally run precommit
with java8...
I made the following change and can confirm this new version works fine with a
java8 compiler set:
{noformat}
Index: common-build.xml
===================================================================
--- common-build.xml (revision 1617955)
+++ common-build.xml (working copy)
@@ -1798,7 +1798,7 @@
<!-- ECJ Javadoc linting: -->
<condition property="ecj-javadoc-lint.supported">
- <not><equals arg1="${build.java.runtime}" arg2="1.8"/></not>
+ <not><equals arg1="${build.java.runtime}" arg2="1.9"/></not>
</condition>
<condition property="ecj-javadoc-lint-tests.supported">
{noformat}
But I think Uwe is right, we should ideally not disable the check like this,
but instead change this to a check for 1.9 (but I don't know how to check for
existence of java 9, we need a new method).
> current ecj-javadoc-lint crashes on SharedFSAutoReplicaFailoverUtilsTest.java
> -----------------------------------------------------------------------------
>
> Key: LUCENE-5886
> URL: https://issues.apache.org/jira/browse/LUCENE-5886
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-5886.patch
>
>
> It seems the version we are using has bugs that are tripped by this test.
> We are using 3.7.2, I think we should upgrade to 4.4?
> It seems to solve the issue for me.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
