[
https://issues.apache.org/jira/browse/LUCENE-5886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-5886:
----------------------------------
Attachment: java9detection.patch
Updated patch:
- uses Robert's mods to Constants.java. I agree, this is much better!
For common-build I used a similar approach:
- We fail, as before for Java < 7. This is a hard fail like before using the
<hasmethod" check (this is easiest).
- {{java.specification.version}} is cleaned up like in constants.java, so it
contains only x.y, any additional stuff after it is removed (so be prepared
with JVMs that suddenly add lower versions. We had this in the past, e.g. with
1.4.1. The cleaned up version is put to temporary property
- The public property {{build.java.runtime}} is then defined as strict enum
(because we have no version comparison magic in ant, so we can just do equals
checks). We therefore detect 3 versions: "1.7", "1.8", "1.9". Everything else
is detected as "unknown". This allow to define conditions, so e.g. disallow
not-yet-known build environments for specific targets/tasks.
- I changed some more conditions, like the ecj one. I prefer them to be
positive, so ecj is now only run if version is in "1.7" or "1.8", everything
else is not supported
- For javadoc generation, i pass -Xdoclint:none for every JVM>1.7 (we still
need to fix our javadocs to be HTML4 and not XHTML)
> current ecj-javadoc-lint crashes on SharedFSAutoReplicaFailoverUtilsTest.java
> -----------------------------------------------------------------------------
>
> Key: LUCENE-5886
> URL: https://issues.apache.org/jira/browse/LUCENE-5886
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-5886.patch, LUCENE-5886.patch, LUCENE-5886.patch,
> java9detection.patch, java9detection.patch
>
>
> It seems the version we are using has bugs that are tripped by this test.
> We are using 3.7.2, I think we should upgrade to 4.4?
> It seems to solve the issue for me.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
