[ 
https://issues.apache.org/jira/browse/SOLR-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated SOLR-6342:
-----------------------------

    Attachment: SOLR-6342.patch

The {{build.xml}} modifications look good to me.  I ran {{ant package}} from 
{{solr/}} and then unpacked each of the three distributions (binary .zip and 
.tgz; source .tgz) and found that {{LUCENE_CHANGES.txt}} is in the expected 
place in each, and its contents are the same as Lucene's {{CHANGES.txt}}.

The attached patch, which includes Hoss's changes, fixes a problem in the 
{{Changes.html}} generated by {{ant changes-to-html}} under {{solr/}}: the 
added per-release text about {{LUCENE_CHANGES.txt}} was improperly added as a 
numbered item under the "Versions of Major Components" section.  I fixed this 
by moving the text  in {{CHANGES.txt}} under each release so that it's the 
first thing under the release header - this makes the text its own item.

In the patch, I've also enabled auto-linkification in {{changes2html.pl}} 
(called by {{ant changes-to-html}}) of {{LUCENE_CHANGES.txt}}, to the 
appropriate Lucene {{Changes.html}} file.

> Solr should mention CHANGES from Lucene which have side effects in Solr
> -----------------------------------------------------------------------
>
>                 Key: SOLR-6342
>                 URL: https://issues.apache.org/jira/browse/SOLR-6342
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Varun Thacker
>         Attachments: SOLR-6342.patch, SOLR-6342.patch
>
>
> This is the problem that I faced - A user upgraded Solr from 4.0 to 4.9 and 
> the queries being formed were behaving differently.
> I tracked it down to LUCENE-5180 ( which I believe is the correct thing to do 
> ) . The problem is since Solr does't ship with the Lucene CHANGES.txt file 
> and we didn't record this under the the Solr CHANGES.txt file also, a user is 
> not aware of such changes when upgrading.
> I can think of two options - 
> 1. Duplicate the changes which have side effects in Solr under Solr's 
> CHANGES.txt file also ( not sure if we do this already and that we missed 
> this one ).
> 2. Be conservative and ship Solr binaries with the Lucene CHANGES.txt file 
> also
> We should address this problem



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to