[
https://issues.apache.org/jira/browse/SOLR-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100747#comment-14100747
]
Erick Erickson edited comment on SOLR-6338 at 8/18/14 3:44 PM:
---------------------------------------------------------------
All of the test failures in TestSolrXml are some form like:
assertEquals("core root dir", "testCoreRootDirectory",
cfg.getCoreRootDirectory());
And can be fixed by adding the trailing slash to the hard-coded string like
this:
assertEquals("core root dir", "testCoreRootDirectory/",
cfg.getCoreRootDirectory());
So the failures are consistent with the changes to the code, at least at a
glance.
I suppose I have to make sure the trailing slash works on Windows for the
tests though.
Now, I've just glanced at the code change, and it seems fine to me. I don't
think
there's any problem with changing the tests to have the trailing slash.
So if anyone wants to weigh in with whether the change has any problems please
do.
Otherwise it seems like we should commit it. I'm running the full test suite
now and unless someone objects I'll commit this shortly.
was (Author: erickerickson):
All of the test failures in TestSolrXml are some form like:
assertEquals("core root dir", "testCoreRootDirectory",
cfg.getCoreRootDirectory());
And can be fixed by adding the trailing slash to the hard-coded string like
this:
assertEquals("core root dir", "testCoreRootDirectory/",
cfg.getCoreRootDirectory());
So the failures are consistent with the changes to the code, at least at a
glance.
Now, I've just glanced at the code change, and it seems fine to me. I don't
think
there's any problem with changing the tests to have the trailing slash.
So if anyone wants to weigh in with whether the change has any problems please
do.
Otherwise it seems like we should commit it. I'm running the full test suite
now and unless someone objects I'll commit this shortly.
> coreRootDirectory requires trailing slash, or SolrCloud cores are created in
> wrong location
> -------------------------------------------------------------------------------------------
>
> Key: SOLR-6338
> URL: https://issues.apache.org/jira/browse/SOLR-6338
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.9
> Environment: x86_64 Linux
> x86_64 Sun Java 1.7.0_51
> Reporter: Virender Khatri
> Assignee: Erick Erickson
> Labels: collection-api
> Fix For: 5.0, 4.10
>
>
> If the coreRootDirectory setting does not end with a filesystem path
> separator, cores are not created in the correct location.
> e.g.
> coreRootDirectory=/usr/local/solr/cores
> For a collection xyz, API creates '/usr/local/solr/coresxyz_shardN_replicaN'
> config directory instead of '/usr/local/solr/cores/xyz_shardN_replicaN'
> Adding a trailing slash to coreRootDirectory is a viable workaround:
> coreRootDirectory=/usr/local/solr/cores/
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
