[ 
https://issues.apache.org/jira/browse/SOLR-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Davids updated SOLR-4406:
-------------------------------

    Attachment: SOLR-4406.patch

Added tests which provides complete code coverage of the RawResponseWriter. I 
didn't go the mocking route, instead it is an integration test by spinning up a 
core to assert 3 different cases:

1) If a content stream is provided send that back in the writer & output stream
2) If no content stream is provided and no base writer is specified verify the 
response is serialized with the default writer (XML)
3) If no content stream is provided and a base writer is specified serialize 
with the specified writer

> RawResponseWriter - doesn't use the configured "base" writer.
> -------------------------------------------------------------
>
>                 Key: SOLR-4406
>                 URL: https://issues.apache.org/jira/browse/SOLR-4406
>             Project: Solr
>          Issue Type: Bug
>          Components: Response Writers
>    Affects Versions: 4.0
>            Reporter: Steve Davids
>         Attachments: SOLR-4406.patch, SOLR-4406.patch, SOLR-4406.patch
>
>
> The RawResponseWriter accepts a configuration value for a "base" 
> ResponseWriter if no ContentStream can be detected. The line of code is 
> commented out that would allow this secondary response writer to work. It 
> would be great to uncomment the line and provide an OutputStreamWriter as the 
> writer argument.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to