[ 
https://issues.apache.org/jira/browse/SOLR-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106527#comment-14106527
 ] 

Shawn Heisey commented on SOLR-6390:
------------------------------------

Looks good.  The javadoc update made me remember just how incomplete the 
javadocs for CloudSolrServer constructors are, and I would recommend using the 
javadocs I created on SOLR-5852.  Look at the latest patch on that issue, from 
23/Jul/14.  That one never got committed, and probably needs to be closed.

Do you want to make a new patch, or leave it for me?


> Remove unnecessary checked exception for CloudSolrServer constructor
> --------------------------------------------------------------------
>
>                 Key: SOLR-6390
>                 URL: https://issues.apache.org/jira/browse/SOLR-6390
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Steve Davids
>            Priority: Trivial
>             Fix For: 5.0
>
>         Attachments: SOLR-6390.patch
>
>
> The CloudSolrServer constructors can be simplified and can remove an 
> unnecessary checked exception for one of the 4 constructors.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to