[ 
https://issues.apache.org/jira/browse/SOLR-6379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112629#comment-14112629
 ] 

Mark Miller commented on SOLR-6379:
-----------------------------------

bq. If that is addressed , I don't really have any objection to the solution 
itself.

You do know the performance cost of that call don't you? 

Anyway, we already make this call in SolrDispatchFilter - if anything, we 
should simply ensure we only call it once. Not that it will buy us any 
performance.

It's not a call we need to strive to avoid calling on any Solr request though.



> CloudSolrServer can query the wrong replica if a collection has a SolrCore 
> name that matches a collection name.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-6379
>                 URL: https://issues.apache.org/jira/browse/SOLR-6379
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Hoss Man
>            Assignee: Anshum Gupta
>            Priority: Minor
>             Fix For: 5.0, 4.10
>
>         Attachments: SOLR-6379.patch, SOLR-6379.patch, SOLR-6379.patch, 
> SOLR-6379.patch, SOLR-6379.patch, SOLR-6379.patch, SOLR-6379.patch, 
> SOLR-6379.pristine_collection.test.patch
>
>
> spin off of SOLR-2894 where sarowe & miller were getting failures from 
> TestCloudPivot that seemed unrelated to any of hte distrib pivot logic itself.
> in particular: adding a call to "waitForThingsToLevelOut" at the start of the 
> test, even before indexing any docs, seemed to work around the problem -- but 
> even if all replicas aren't yet up when the test starts, we should either get 
> a failure when adding docs (ie: no replica hosting the target shard) or 
> queries should only be routed to the replicas that are up and fully caught up 
> with the rest of the collection.
> (NOTE: we're specifically talking about a situation where the set of docs in 
> the collection is static during the query request)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to