[
https://issues.apache.org/jira/browse/LUCENE-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971510#action_12971510
]
Earwin Burrfoot commented on LUCENE-2811:
-----------------------------------------
>From IRC:
SegmentMerger.hasVectors carries no new information compared to
OneMerge.hasVectors, and can be dropped.
OneMerge.hasVectors is initialized just near OneMerge.info, and is later used
to set OneMerge.info.hasVectors, might as well do that from the get go and drop
OM.hV.
> SegmentInfo should explicitly track whether that segment wrote term vectors
> ---------------------------------------------------------------------------
>
> Key: LUCENE-2811
> URL: https://issues.apache.org/jira/browse/LUCENE-2811
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2811.patch
>
>
> Today SegmentInfo doesn't know if it has vectors, which means its files()
> method must check if the files exist.
> This leads to subtle bugs, because Si.files() caches the files but then we
> fail to invalidate that later when the term vectors files are created.
> It also leads to sloppy code, eg TermVectorsReader "gracefully" handles being
> opened when the files do not exist. I don't like that; it should only be
> opened if they exist.
> This also fixes these intermittent failures we've been seeing:
> {noformat}
> junit.framework.AssertionFailedError: IndexFileDeleter doesn't know about
> file _1e.tvx
> at
> org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:979)
> at
> org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:917)
> at
> org.apache.lucene.index.IndexWriter.filesExist(IndexWriter.java:3633)
> at
> org.apache.lucene.index.IndexWriter.startCommit(IndexWriter.java:3699)
> at
> org.apache.lucene.index.IndexWriter.prepareCommit(IndexWriter.java:2407)
> at
> org.apache.lucene.index.IndexWriter.commitInternal(IndexWriter.java:2478)
> at org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:2460)
> at org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:2444)
> at
> org.apache.lucene.index.TestIndexWriterExceptions.testRandomExceptionsThreads(TestIndexWriterExceptions.java:213)
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
