I was responding to Uwe's comment about using nio for file perms. It's tangential though I agree. And I missed the fact that this patch wasn't committed yet when looking at the code. Well, it is as I write this...
For the nonce I'm going to pass on this issue though. I think it needs some more thought on my part and we're using File.setWriteable() in other places so this'll be part of a bigger migration I think. On Thu, Sep 4, 2014 at 9:09 AM, Robert Muir <rcm...@gmail.com> wrote: > Erick, I dont think you looked at the commit or patch. There is no > such thing for Files.delete. > > So maybe you are discussing something unrelated to the issue (i > recommend a separate thread). > > On Thu, Sep 4, 2014 at 12:00 PM, Erick Erickson <erickerick...@gmail.com> > wrote: >> Wait. A quick look at the nio.files.Files class and... >> >> In the brave new world here are we requiring that we test first to see >> what the filesystem is? Because there's Posix and Dos varieties that >> seem to be invoked separately. I don't see anywhere else in the code >> base where we do this, am I the first or am I just dense? >> >> On Thu, Sep 4, 2014 at 8:56 AM, ASF subversion and git services (JIRA) >> <j...@apache.org> wrote: >>> >>> [ >>> https://issues.apache.org/jira/browse/LUCENE-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121491#comment-14121491 >>> ] >>> >>> ASF subversion and git services commented on LUCENE-5906: >>> --------------------------------------------------------- >>> >>> Commit 1622506 from [~rcmuir] in branch 'dev/trunk' >>> [ https://svn.apache.org/r1622506 ] >>> >>> LUCENE-5906: Use Files.delete everywhere instead of File.delete >>> >>>> Use Files.delete instead of File.delete + made up exception >>>> ----------------------------------------------------------- >>>> >>>> Key: LUCENE-5906 >>>> URL: https://issues.apache.org/jira/browse/LUCENE-5906 >>>> Project: Lucene - Core >>>> Issue Type: Bug >>>> Reporter: Robert Muir >>>> Attachments: LUCENE-5906.patch, LUCENE-5906.patch, >>>> LUCENE-5906.patch, LUCENE-5906.patch, LUCENE-5906.patch >>>> >>>> >>>> We are on java7, if we cannot delete a file, this one returns a real >>>> exception as to why. >>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v6.3.4#6332) >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> For additional commands, e-mail: dev-h...@lucene.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
