[ https://issues.apache.org/jira/browse/SOLR-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123824#comment-14123824 ]
ASF subversion and git services commented on SOLR-6457: ------------------------------------------------------- Commit 1622818 from [~noble.paul] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1622818 ] SOLR-6457 > LBHttpSolrServer: AIOOBE risk if counter overflows > -------------------------------------------------- > > Key: SOLR-6457 > URL: https://issues.apache.org/jira/browse/SOLR-6457 > Project: Solr > Issue Type: Bug > Components: clients - java > Affects Versions: 4.0, 4.1, 4.2, 4.2.1, 4.3, 4.3.1, 4.4, 4.5, 4.5.1, 4.6, > 4.6.1, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1, 4.9 > Reporter: longkeyy > Assignee: Noble Paul > Labels: patch > Attachments: SOLR-6457.patch > > > org.apache.solr.client.solrj.impl.LBHttpSolrServer > line 442 > int count = counter.incrementAndGet(); > ServerWrapper wrapper = serverList[count % serverList.length]; > when counter overflows, the mod operation of > "count % serverList.length" will start trying to use negative numbers as > array indexes. > suggess to fixup it ,eg: > //keep count is greater than 0 > int count = counter.incrementAndGet() & 0x7FFFFFF; -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org