[
https://issues.apache.org/jira/browse/SOLR-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135583#comment-14135583
]
Per Steffensen commented on SOLR-6522:
--------------------------------------
bq. After a quick scan, I think most of these are appropriate for info level
(given how we already use info level).
Ok, then maybe you should consider "the way you use info-level" :-)
bq. It's been very useful in the past to see when a commit starts and ends when
debugging a customer problem.
The keyword is "debugging". That kind of stuff belongs on debug-level
But of course I understand that when you get a log from a customer that he
picked up after an error occurred, it is hard to tell him to turn on
debug-level and make the error occur again :-) But I guess there is not a
single log-line in the code where you cannot say that it would be useful to
have the output from that line when debugging a problem in that area of the
code - and still log-lines using debug-level exists in the code
bq. Also, stuff like "Committing on IndexWriter close." is a rare event.
Yeahhh ok, actually it is the start/end loggings that are bothering us. I just
went through the file to see if there where other lines that potentially
belonged on debug-level, and came up with a few additional
-------------
But ok, if you have arguments not to do the change, that is perfectly ok. I
guess I will live with it. Thanks for responding!
> DirectUpdateHandler2 - log start/end on debug-level
> ---------------------------------------------------
>
> Key: SOLR-6522
> URL: https://issues.apache.org/jira/browse/SOLR-6522
> Project: Solr
> Issue Type: Improvement
> Components: update
> Reporter: Per Steffensen
> Priority: Trivial
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There are some loggings in {{DirectUpdateHandler2}} on info-level that I
> believe ought to be on debug-level. That is
> * All the {{log.info("start ...);}} and {{log.info("end ...);}} loggings
> * {{log.info("No uncommitted changes. Skipping IW.commit.");}}
> * {{log.info("Committing on IndexWriter close.");}}
> Reason I want it changed is that we log something on info-level (that really
> belongs on info-level) in our extended version of {{DirectUpdateHandler2}},
> and we want that logged without filling up our log-files with the stuff
> mentioned above. Now that is not especially relevant for Apache Solr, but
> besides that I believe that this change is "the right thing to do", and that
> it should therefore be done.
> In general I believe it would be a good idea to scan the entire code-base to
> see if we log on the "right" level - I believe there are lots of places
> around the code where the log-level is chosen "by random". But I will leave
> that to other issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
