[ 
https://issues.apache.org/jira/browse/LUCENE-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973046#action_12973046
 ] 

Michael McCandless commented on LUCENE-2694:
--------------------------------------------

{quote}
I disagree on that - at least docFreq() is an essential part of the API and we 
should not force TermState creation just to get the df. Yet, TermState is an 
expert API you should not need to pull an expert API to get something essential 
like df.
I would leave those as they are or only pull ord into TermState.
{quote}

OK I agree, let's leave at least dF directly in TermsEnum.

Calling .termState presumably entails a clone right?  Ie the returned object is 
guaranteed private?  So that's a good reason not to require it...

{quote}
I actually had this in a very similar way. I used a custom linked list and 
relied on the fact that the incoming reader are applied in the same order and 
skipped until the next reader with that term appeared. I changed that back to 
Map impl to make it simpler since I didn't see speedups - well this was caused 
by a very nifty coding error 
{quote}

Let's just stick w/ map for now I think?  Progress not perfection!

> MTQ rewrite + weight/scorer init should be single pass
> ------------------------------------------------------
>
>                 Key: LUCENE-2694
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2694
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Search
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.0
>
>         Attachments: LUCENE-2694-FTE.patch, LUCENE-2694.patch, 
> LUCENE-2694.patch, LUCENE-2694.patch, LUCENE-2694.patch
>
>
> Spinoff of LUCENE-2690 (see the hacked patch on that issue)...
> Once we fix MTQ rewrite to be per-segment, we should take it further and make 
> weight/scorer init also run in the same single pass as rewrite.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to