[
https://issues.apache.org/jira/browse/LUCENE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Thacker updated LUCENE-5833:
----------------------------------
Attachment: LUCENE-5833.patch
New patch with the changes that you recommended -
1. Renamed currentFieldsPosition name it nextFieldsPosition
2. Moved to the following syntax - {code} if (fieldVal.binaryValue() != null) {
return fieldVal.binaryValue();
} else if (fieldValue.stringValue() != null) {
return new BytesRef(fieldValue.stringValue());
} else {
continue;
}{code}
Although I like the payload condition check the way it is currently because of
the added null check.
bq. Can you pull out the atLeast(N) from the for loops,
Absolutely. I don't know how I overlooked that ;)
> Suggestor Version 2 doesn't support multiValued fields
> ------------------------------------------------------
>
> Key: LUCENE-5833
> URL: https://issues.apache.org/jira/browse/LUCENE-5833
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/other
> Affects Versions: 4.8.1
> Reporter: Greg Harris
> Assignee: Steve Rowe
> Attachments: LUCENE-5833.patch, LUCENE-5833.patch, LUCENE-5833.patch,
> SOLR-6210.patch
>
>
> So if you use a multiValued field in the new suggestor it will not pick up
> terms for any term after the first one. So it treats the first term as the
> only term it will make it's dictionary from.
> This is the suggestor I'm talking about:
> https://issues.apache.org/jira/browse/SOLR-5378
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
