[ https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152339#comment-14152339 ]
Steve Rowe commented on SOLR-6476: ---------------------------------- {quote} bq. One of the tests should have a non-trivial fieldtype definition, like at least one analyzer. It is not supported yet. Pls correct me if I am wrong. does the current REST API support it? {quote} Yes. See {{TestManagedSchemaFieldTypeResource}}. {quote} bq. Most of the add*() javadocs in IndexSchema say that persistence always happens, but it doesn't if persist=false It says "* @param persist to persist or not" . Isn't it right? {quote} This is what I'm talking about: "Copies this schema, adds the given fields to the copy, then persists the new schema." {quote} bq. {{SchemaManager}} has zero javadocs. More would be good. It is not a class for others to use . But , it will be added {quote} Thanks. Javadocs (or rather comments of any kind) are for maintainers too, not just users. Here's an example where javadocs/comments would help a maintainer: {{SchemaManager.Operation.getMetaWithout()}}. What does that thing do? (Hint: the name of the method doesn't tell you.) > Create a bulk mode for schema API > --------------------------------- > > Key: SOLR-6476 > URL: https://issues.apache.org/jira/browse/SOLR-6476 > Project: Solr > Issue Type: Bug > Components: Schema and Analysis > Reporter: Noble Paul > Assignee: Noble Paul > Labels: managedResource > Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, > SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch > > > The current schema API does one operation at a time and the normal usecase is > that users add multiple fields/fieldtypes/copyFields etc in one shot. > example > {code:javascript} > curl http://localhost:8983/solr/collection1/schema -H > 'Content-type:application/json' -d '{ > "add-field": { > "name":"sell-by", > "type":"tdate", > "stored":true > }, > "add-field":{ > "name":"catchall", > "type":"text_general", > "stored":false > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org