Because browsers don't care? The link which caused the jenkins failure with this worked just fine when I tested it manually.
On Tue, Sep 30, 2014 at 10:18 AM, Chris Hostetter <hossman_luc...@fucit.org> wrote: > > I'm confused: why are we telling this link checker that it is "ok" to have > whitespace in the middle of a URL? > > > : Date: Wed, 24 Sep 2014 20:18:31 -0000 > : From: rjer...@apache.org > : Reply-To: dev@lucene.apache.org > : To: comm...@lucene.apache.org > : Subject: svn commit: r1627410 - > : /lucene/dev/trunk/dev-tools/scripts/checkJavadocLinks.py > : > : Author: rjernst > : Date: Wed Sep 24 20:18:31 2014 > : New Revision: 1627410 > : > : URL: http://svn.apache.org/r1627410 > : Log: > : Account for whitespace in the middle of links when checking javadoc links > : > : Modified: > : lucene/dev/trunk/dev-tools/scripts/checkJavadocLinks.py > : > : Modified: lucene/dev/trunk/dev-tools/scripts/checkJavadocLinks.py > : URL: > http://svn.apache.org/viewvc/lucene/dev/trunk/dev-tools/scripts/checkJavadocLinks.py?rev=1627410&r1=1627409&r2=1627410&view=diff > : > ============================================================================== > : --- lucene/dev/trunk/dev-tools/scripts/checkJavadocLinks.py (original) > : +++ lucene/dev/trunk/dev-tools/scripts/checkJavadocLinks.py Wed Sep 24 > 20:18:31 2014 > : @@ -177,6 +177,9 @@ def checkAll(dirName): > : else: > : anchor = None > : > : + # remove any whitespace from the middle of the link > : + link = ''.join(link.split()) > : + > : idx = link.find('?') > : if idx != -1: > : link = link[:idx] > : > : > : > > -Hoss > http://www.lucidworks.com/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > >
