[
https://issues.apache.org/jira/browse/SOLR-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe reopened SOLR-6476:
------------------------------
Noble, you apparently ignored this comment I made earlier when you committed -
it's still a problem:
{quote}
In {{SchemaManager.waitForOtherReplicasToUpdate()}}, called from
{{doOperations()}}, you send -1 in as {{maxWaitSecs}} to
{{ManagedIndexSchema.waitForSchemaZkVersionAgreement()}} when the timeout has
been exceeded, but AFAICT negative values aren't handled appropriately there,
e.g. it gets sent in unexamined to {{ExecutorService.invokeAll()}}:
{quote}
Two more issues:
1. It's better form to use the conversion function for
nanoseconds->milliseconds rather than having constant conversion factors - you
have (starting at line #159 in {{SchemaManager}}):
{code:java}
long timeLeftSecs1 = timeout - ((System.nanoTime() - startTime) /1000000);
[...]
long timeLeftSecs = timeout - ((System.nanoTime() - startTime) /1000000);
{code}
But everywhere else in Solr, e.g. line #178 in {{HttpShardHandler}}:
{code:java}
ssr.elapsedTime = TimeUnit.MILLISECONDS.convert(System.nanoTime() - startTime,
TimeUnit.NANOSECONDS);
{code}
2. Aren't you going to backport this to branch_5x?
> Create a bulk mode for schema API
> ---------------------------------
>
> Key: SOLR-6476
> URL: https://issues.apache.org/jira/browse/SOLR-6476
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: Noble Paul
> Assignee: Noble Paul
> Labels: managedResource
> Fix For: Trunk
>
> Attachments: SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch, SOLR-6476.patch,
> SOLR-6476.patch
>
>
> The current schema API does one operation at a time and the normal usecase is
> that users add multiple fields/fieldtypes/copyFields etc in one shot.
> example
> {code:javascript}
> curl http://localhost:8983/solr/collection1/schema -H
> 'Content-type:application/json' -d '{
> "add-field": {
> "name":"sell-by",
> "type":"tdate",
> "stored":true
> },
> "add-field":{
> "name":"catchall",
> "type":"text_general",
> "stored":false
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
